Feature/4 std config #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbt-header check + github workflow
…-compatiblity), created issue #5 to follow up
…oString returning `Boolean` vs `scala.Boolean` + test
…dationFailure` renamed to `FieldValidationIssue`
build name = small caps,
…ed to `StandardizationCsvSuite`
…ns to read configs. Tests adjusted
Closed
Closed
% Conflicts: % src/main/scala/za/co/absa/standardization/Standardization.scala % src/main/scala/za/co/absa/standardization/StandardizationConfig.scala % src/test/scala/za/co/absa/standardization/StandardizationParquetSuite.scala
Zejnilovic
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #4 mentions other properties, however, those may not be part of Standardization after all.
This PR merely uses
StandardizationConfig(typed config) instead of a free-form typesafe config object.StandardizationConfigcontains means to read ts config (as Standardization should maintain the proper level of abstraction).Existing tests have been updated to reflect this change.
(merge after #1,
currently based on #1, may get rebased)