Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and refactor template builder #5 #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify and refactor template builder #5 #10

wants to merge 1 commit into from

Conversation

jordihereu
Copy link

  • Refactor: extract logic to calculate sizeSpacing into a private function GetSizsSpacing(). Remove unused setSize var
  • Refactor: extract logic to draw the rectangle into several functions: GetStatusPos, GetStatusBar and finally DrawARectangle
  • Remove green code
  • Fix wrong indentation

@jordihereu
Simplify and refactor template builder AbnerSquared#5
2b1428e 
- Refactor: extract logic to calculate sizeSpacing into a private function GetSizsSpacing(). Remove unused setSize var
- Refactor: extract logic to draw the rectangle into several functions: GetStatusPos, GetStatusBar and finally DrawARectangle
- Remove green code
- Fix wrong indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jordihereu