Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #95: Add new_data as a DataStore class attribute #96

Merged

Conversation

LorenzzoQM
Copy link
Contributor

Description

Closes #95

Added an attribute to DataStorage class to store the most recent value of new_data so it can be accessed outside the class.

How should this pull request be reviewed?

  • By commit
  • All changes at once

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Unit tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
  • Integrated tests (General Environment only) pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration

Test Configuration

  • Python: [e.g. 3.11.5]
  • Basilisk: [e.g. 2.2.1b0]
  • Platform: [MacOs 14.1.2]

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LorenzzoQM LorenzzoQM self-assigned this Dec 7, 2023
@LorenzzoQM LorenzzoQM requested a review from Mark2000 December 7, 2023 18:36
@LorenzzoQM LorenzzoQM merged commit 68839e6 into develop Dec 7, 2023
8 checks passed
@LorenzzoQM LorenzzoQM deleted the Issue/#95_access_new_data_outside_DataStore_class branch December 7, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access new_data variable outside the DataStore class
2 participants