Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #194: Check that docs build on PR #196

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

Mark2000
Copy link
Contributor

Description

Closes #194

Note: require this check once PR is merged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How should this pull request be reviewed?

  • By commit
  • All changes at once

How Has This Been Tested?

Tested by GitHub

Checklist:

  • My code follows the style guidelines of this project (passes Black, ruff, and isort)
  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation and release notes
  • Commit messages are atomic, are in the form Issue #XXX: Message and have a useful message
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • If I changed an example ipynb, I have locally rebuilt the documentation

@Mark2000 Mark2000 force-pushed the feature/194-doc-build-req branch 2 times, most recently from aa0ac5d to 0e8b92e Compare September 23, 2024 18:06
@Mark2000 Mark2000 force-pushed the feature/194-doc-build-req branch from 0e8b92e to e233f2a Compare September 30, 2024 15:47
@Mark2000 Mark2000 merged commit ed50428 into develop Sep 30, 2024
5 checks passed
@Mark2000 Mark2000 deleted the feature/194-doc-build-req branch September 30, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that documentation builds to allow merging PR
2 participants