-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #106: Implement logging module #107
Conversation
src/bsk_rl/envs/general_satellite_tasking/scenario/satellites.py
Outdated
Show resolved
Hide resolved
b71ab21
to
54a01e2
Compare
Pushed fixes that should eliminate erroneous logging. Also fixed the logger when multiple environments are instantiated, sequentially, could still be a problem in parallel applications, like training. Will read up on logging filters and think about it more. |
54a01e2
to
a3ee5ee
Compare
a3ee5ee
to
c2a0996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the three log levels; for now, I think they are enough. I also agree with the amount of information being logged at each level. Over time, we can add more if we see it as necessary. This is an excellent feature to have!
@@ -0,0 +1,21 @@ | |||
import logging | |||
|
|||
sim_format = logging.Formatter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think adding a color scheme would be interesting to make it easier to identify when it is INFO, DEBUG, or WARNING? Something like blue, brown, and yellow would help (maybe just the words info, debug, and warning), especially when debugging when we have a lot of info (if it is not too much work now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is it worth adding the option to save the log in a file? I can see some cases where it might be useful and easier to use the file than the terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was considering adding to-file logging, should be pretty easy I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! The colors look nice!
Description
Closes #106
Implements the python logging module. @LorenzzoQM would be interested to hear your opinions about if we should log less/more and what logging levels are appropriate. There's a lot that could be done here, like coloring logs, etc. but this feels like a good minimal product.
How should this pull request be reviewed?
Type of change
How Has This Been Tested?
Updated tests.
pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/unittest
pytest --cov bsk_rl/envs/general_satellite_tasking --cov-report term-missing tests/integration
Test Configuration
Checklist:
Issue #XXX: Message
and have a useful message