-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commited WiP files for publication #833
Conversation
* both files will be removed before this work is finished * these are my current thoughts and first implementation * this is not integrated into Askbot. You can read deployments.md locally and run dev_django.py in a virtualenv to play around with the classes.
Re: overwriting files by the install script - I agree, it's not necessary, we should just tell them - either reconcile the files manually or choose a new directory. On the directory structure: imo as default solution your proposal works, but I would leave an option to specify custom locations of docs, cron, upfiles, logs. (docs may be suppressed, because not everyone needs them) Also I have quite a strong wish in the default directory structure to move "cron", "upfiles", "docs" dirs directly alongside with the manage.py. It's just that flatter is better than nested;). Thank you for your effort! |
! Apparently the installer (and tox) requre the env var SECRET_KEY to be set in current 0.11.x upstream * created deploy_askbot_new() and use it as a drop in replacement for deploy_askbot() * modified deployed directory structure to include Evgeny's suggestion from ASKBOT#833 * Added new deployable EmptyFile to accomodate the empty log file
…ctory layout * see ASKBOT#833
When we just look at creating files and directories, I think this is a viable approach. I added unittests that suggests everything works just fine, if sensible parameters are provided. Still not done. For best results this should be used/merged with #827. I haven't attempted this yet! |
DO NOT MERGE THIS! THIS IS FOR REVIEW ONLY! The logic seems in a pretty good state now. When I run
( There are nine unit tests that ensure the basic functionality of the This branch already includes @evgenyfadeev 's comment on changing the layout and the installer giving user feedback instead of overwriting existing files. I'll go ahead and create a new branch where I merge this branch and the one for #827. |
Superceeded by #849 |
locally and run dev_django.py in a virtualenv to play around with
the classes.