Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround isce2 setting root logger to debug #177

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

scottyhq
Copy link
Contributor

Fixes #176

Ideally, the fix would be to isce2, but it's been a known problem for a while (isce-framework/isce2#258)...

@scottyhq scottyhq requested a review from a team January 12, 2024 01:11
Copy link
Contributor

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I agree this should be handled by ISCE2 but that issue is approaching 3 years old at this point, so I don't see that happening anytime soon.

Copy link
Contributor

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just added a changelog entry, fixed a listing issue, and added some more info to the logging comment.

@jhkennedy jhkennedy merged commit 6d09de5 into ASFHyP3:develop Jan 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

botocore.exceptions.ConnectTimeoutError and lots of DEBUG outputs
2 participants