Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mypy Action for Type Checking #112

Merged
merged 15 commits into from
Jan 15, 2025
Merged

Add mypy Action for Type Checking #112

merged 15 commits into from
Jan 15, 2025

Conversation

AndrewPlayer3
Copy link
Contributor

No description provided.

.github/workflows/static-analysis.yml Dismissed Show dismissed Hide dismissed
@AndrewPlayer3 AndrewPlayer3 marked this pull request as ready for review January 14, 2025 17:43
@AndrewPlayer3 AndrewPlayer3 requested a review from a team January 14, 2025 17:43
Copy link
Contributor

@jtherrmann jtherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out mypy wasn't flagging most of the errors because there's no __init__.py, I opened #113 to fix that.

@forrestfwilliams
Copy link
Contributor

burst2safe S1_136231_IW2_20200604T022312_VV_7C85-BURST S1_136232_IW2_20200604T022315_VV_7C85-BURST

Is failing with the exception:

Traceback (most recent call last):
  File "/Users/ffwilliams2/miniforge3/envs/burst2safe/bin/burst2safe", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/ffwilliams2/Repositories/burst2safe/src/burst2safe/burst2safe.py", line 108, in main
    burst2safe(
  File "/Users/ffwilliams2/Repositories/burst2safe/src/burst2safe/burst2safe.py", line 72, in burst2safe
    safe_path = safe.create_safe()
                ^^^^^^^^^^^^^^^^^^
  File "/Users/ffwilliams2/Repositories/burst2safe/src/burst2safe/safe.py", line 438, in create_safe
    self.create_safe_components()
  File "/Users/ffwilliams2/Repositories/burst2safe/src/burst2safe/safe.py", line 304, in create_safe_components
    swath.write()
  File "/Users/ffwilliams2/Repositories/burst2safe/src/burst2safe/swath.py", line 155, in write
    assert self.measurement.data_mean is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

@AndrewPlayer3 AndrewPlayer3 merged commit 9c47b01 into develop Jan 15, 2025
12 checks passed
@AndrewPlayer3 AndrewPlayer3 deleted the mypy branch January 15, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants