Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workloads/speedometer: Dismiss notification pop-up #1260

Merged
merged 1 commit into from
May 30, 2024
Merged

workloads/speedometer: Dismiss notification pop-up #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions wa/workloads/speedometer/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@ def setup(self, context):
'<boolean name="first_run_tos_accepted" value="true" />\n',
'<boolean name="first_run_signin_complete" value="true" />\n',
'<boolean name="displayed_data_reduction_promo" value="true" />\n',
# Add a 'request count' value to dismiss the pop-up window on the screen.
# If the value is greater than 1, pop-up window will be dismissed.
'<int name="Chrome.NotificationPermission.RequestCount" value="2" />\n',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Would it be worth adding a comment to the code so we know what this line had been added to achieve going forward?

]:
lines.insert(len(lines) - 1, line)

Expand Down
Loading