Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delimiter so CMake reads string as a list #593

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dcandler
Copy link
Collaborator

The libraries_supported property is a comma separated list, but CMake uses semi-colons to understand lists. Replacing the character will allow CMake to check which libraries are set within.

The libraries_supported property is a comma separated list, but CMake
uses semi-colons to understand lists. Replacing the character will
allow CMake to check which libraries are set within.
Copy link
Collaborator

@statham-arm statham-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good. I feared you might have changed the JSON strings to use ;, which would be ugly! I prefer this way round.

(I suppose another option would be to use an actual JSON list, but I assume that's 10 lines of cmakery instead of just 1?)

@dcandler
Copy link
Collaborator Author

I did consider using an actual list in the JSON, but yes, it would be even more CMake scripting to find (and then correctly decrement) the length of the list, and leaving it comma separated is still just as readable.

@dcandler dcandler merged commit 776a44c into ARM-software:main Dec 10, 2024
1 check passed
@dcandler dcandler deleted the fix_list branch January 14, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants