Skip to content
This repository has been archived by the owner on May 11, 2024. It is now read-only.

Bump arklib version to 0d25eb0 #14

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Bump arklib version to 0d25eb0 #14

merged 11 commits into from
Jan 3, 2024

Conversation

kirillt
Copy link
Member

@kirillt kirillt commented Dec 22, 2023 •
edited
Loading

Adapting to renamings and changed signatures.

  • Fix links saving

kirillt
kirillt commented Dec 22, 2023
View reviewed changes
@kirillt kirillt mentioned this pull request Dec 22, 2023
Open
@kirillt kirillt mentioned this pull request Dec 29, 2023
Closed
@kirillt kirillt assigned alvinosh and unassigned Rizary Jan 2, 2024
@kirillt
Copy link
Member Author

kirillt commented Jan 2, 2024 •
edited
Loading

Indexing works and now I can verify that ARK-Builders/arklib#34 is fixed.

But links creation stores the properties by incorrect location .ark/meta/<id>. I don't understand why this location is used, it is deprecated constant. I see that arklib link::save method is called and latest 0d25eb0 revision of arklib is used. This revision uses PROPERTIES_STORAGE_FOLDER: &str = "user/properties" for links properties, and .ark/meta is not used at all.

@kirillt kirillt merged commit 464f7d2 into main Jan 3, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@alvinosh alvinosh

Labels
None yet
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirillt @Rizary @alvinosh