Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major refactor to Python v3 #59

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented Nov 3, 2022

@prjemian prjemian added the enhancement New feature or request label Nov 3, 2022
@prjemian prjemian self-assigned this Nov 3, 2022
@prjemian prjemian marked this pull request as draft November 3, 2022 23:31
@prjemian
Copy link
Contributor Author

prjemian commented Nov 8, 2022

This needs its own environment. The environment in use (bluesky_2022_3) has some problems importing spec2nexus:

(bluesky_2022_3) usaxs@usaxscontrol ~/.../jemian/livedata $ which python
/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/bin/python
(bluesky_2022_3) usaxs@usaxscontrol ~/.../jemian/livedata $ python -c "import spec2nexus"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/spec2nexus/__init__.py", line 8, in <module>
    __version__ = get_version()
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/__init__.py", line 147, in get_version
    maybe_version = _get_version(config)
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/__init__.py", line 154, in _get_version
    parsed_version = _do_parse(config)
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/__init__.py", line 101, in _do_parse
    version = _version_from_entrypoints(config) or _version_from_entrypoints(
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/_entrypoints.py", line 66, in _version_from_entrypoints
    version: ScmVersion | None = _call_entrypoint_fn(root, config, ep.load())
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/_entrypoints.py", line 40, in _call_entrypoint_fn
    return fn(root, config=config)
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/git.py", line 181, in parse
    return _git_parse_inner(
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/git.py", line 224, in _git_parse_inner
    return meta(
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/version.py", line 226, in meta
    parsed_version = _parse_tag(tag, preformatted, config)
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/version.py", line 202, in _parse_tag
    version = tag_to_version(tag, config)
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/setuptools_scm/version.py", line 97, in tag_to_version
    version = config.version_cls(version_str)
  File "/home/beams11/USAXS/micromamba/envs/bluesky_2022_3/lib/python3.10/site-packages/packaging/version.py", line 266, in __init__
    raise InvalidVersion(f"Invalid version: '{version}'")
packaging.version.InvalidVersion: Invalid version: '08-ops'

@prjemian
Copy link
Contributor Author

prjemian commented Nov 8, 2022

Confirmed that problem is local to the environment by creating test environment: micromamba create -n s2n -c conda-forge spec2nexus

@prjemian
Copy link
Contributor Author

prjemian commented Nov 8, 2022

This is not a problem with a new environment setup: https://github.com/BCDA-APS/use_bluesky/blob/main/install/environment_2023_1.yml

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2022

This pull request introduces 6 alerts when merging 1df421b into f667fcc - view on LGTM.com

new alerts:

  • 4 for Comparison of identical values
  • 1 for Suspicious unused loop iteration variable
  • 1 for Accepting unknown SSH host keys when using Paramiko

@lgtm-com
Copy link

lgtm-com bot commented Nov 8, 2022

This pull request introduces 6 alerts when merging c529281 into f667fcc - view on LGTM.com

new alerts:

  • 4 for Comparison of identical values
  • 1 for Suspicious unused loop iteration variable
  • 1 for Accepting unknown SSH host keys when using Paramiko

@lgtm-com
Copy link

lgtm-com bot commented Nov 9, 2022

This pull request introduces 6 alerts when merging 314c9b3 into f667fcc - view on LGTM.com

new alerts:

  • 4 for Comparison of identical values
  • 1 for Suspicious unused loop iteration variable
  • 1 for Accepting unknown SSH host keys when using Paramiko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major refactor: Python 3.8+ and use pvWebMonitor
1 participant