Fix indexing error in computing the advective term for #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-conservative tracers. In practice, this makes little difference because it's multiplied by div(Umac) which the MAC projection just enforced to be numerically zero to within its tolerance. Also make the density field non-constant and add a second, non-conservative tracer in the tracer_adv_diff_cn regression test.
asalmgren
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-conservative tracers. In practice, this makes little difference because it's multiplied by div(Umac) which the MAC projection just enforced to be numerically zero to within its tolerance.
Also make the density field non-constant and add a second, non-conservative tracer in the tracer_adv_diff_cn regression test. This will require creating new benchmarks for the 2D and 3D tests.