Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy comm flags in make_alike #4341

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Copy comm flags in make_alike #4341

merged 1 commit into from
Feb 21, 2025

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Feb 21, 2025 •
edited
Loading

Need to make sure these are preserved (we use them as IO flags in WarpX)

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from ax3l February 21, 2025 22:43
@ax3l ax3l added the bug label Feb 21, 2025
ax3l
ax3l approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch!

@ax3l ax3l enabled auto-merge (squash) February 21, 2025 22:46
@ax3l ax3l self-assigned this Feb 21, 2025
@ax3l ax3l mentioned this pull request Feb 21, 2025
Open
@ax3l ax3l merged commit 612e7e2 into AMReX-Codes:development Feb 21, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @ax3l