Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Names in PC::make_alike #4322

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 4, 2025

Summary

The ParticleContainer's make_alike function must not forget the names of the SoA components. Currently, it creates a new container with the same components, but default names.

Additional background

First seen in ECP-WarpX/WarpX#5481

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l added the bug label Feb 4, 2025
@ax3l ax3l requested review from atmyers and WeiqunZhang February 4, 2025 01:29
@ax3l ax3l force-pushed the fix-amrex-make-alike-named branch 2 times, most recently from 0caf0ae to dc68e02 Compare February 4, 2025 01:37
@ax3l
Copy link
Member Author

ax3l commented Feb 4, 2025

Wait, there is more to it. Have to also set the compile-time names.

@ax3l ax3l force-pushed the fix-amrex-make-alike-named branch from dc68e02 to c1be6b8 Compare February 4, 2025 02:41
The ParticleContainer's `make_alike` function forgot the names
of the SoA components.
@ax3l ax3l force-pushed the fix-amrex-make-alike-named branch from c1be6b8 to 22f2d43 Compare February 4, 2025 04:59
@ax3l
Copy link
Member Author

ax3l commented Feb 4, 2025

Now it's complete.

@ax3l ax3l merged commit 78bdf0f into AMReX-Codes:development Feb 4, 2025
72 of 75 checks passed
@ax3l ax3l deleted the fix-amrex-make-alike-named branch February 4, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants