Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When available, this uses the HIP stream-ordered memory allocator
hipMallocAsync
/hipFreeAsync
to make device arena allocations. This should improve performance (performance testing TBD).AMReX tests pass on MI210 with ROCm 6.0.
Closes #3979.
Additional background
ROCm 5.2.0 added these APIs: https://rocm.docs.amd.com/en/latest/about/changelog.html#id665
HIP documentation: https://rocm.docs.amd.com/projects/HIP/en/latest/doxygen/html/group___stream_o.html
The CUDA stream-ordered allocator is already used by AMReX (with CUDA >= 11.2).
Checklist
The proposed changes: