3d anisotropic eb #3907
Merged
3d anisotropic eb #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I'm thinking it might be less confusing to just set axm (not axmt) to apx(i,j,k) so we don't have to redefine all of those at line 113 ... then just swap axm and axmt in lines 54-112. |
asalmgren
approved these changes
Apr 30, 2024
WeiqunZhang
reviewed
Apr 30, 2024
| Real dapx = (axm - axp)*(dx[1]*dx[2]); | ||
| Real dapy = (aym - ayp)*(dx[0]*dx[2]); | ||
| Real dapz = (azm - azp)*(dx[0]*dx[1]); | ||
| const Real apnorm = std::sqrt(dapx*dapx+dapy*dapy+dapz*dapz) + 1.e-30_rt*std::sqrt(dx[0]*dx[1]*dx[2]); |
There was a problem hiding this comment.
The second term has a different units than the first. The first term is L^2, whereas the second is L^(3/2).
WeiqunZhang
reviewed
Apr 30, 2024
| @@ -121,7 +124,7 @@ void set_eb_data (const int i, const int j, const int k, | |||
| return; | |||
| } | |||
|
|
|||
| Real bainv = 1.0_rt/barea(i,j,k); | |||
| Real bainv = bareascaling*bareascaling/apnorm; | |||
There was a problem hiding this comment.
This is the only place bareascaling is used. barescaling is computed with std::sqrt(..). So maybe sqrt is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional background
Creating draft PR to run tests
Checklist
The proposed changes: