Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a HIP/Frontier issue #3902

Merged
merged 3 commits into from
Apr 20, 2024
Merged

fix a HIP/Frontier issue #3902

merged 3 commits into from
Apr 20, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented Apr 20, 2024

Summary

the amrex::single_task(amrex_check_wavefront_size) check causes runtime errors

this is the check that Weiqun suggested in #3901 and I've tested that it works
on Frontier with Castro

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

zingale and others added 3 commits April 20, 2024 14:29
@zingale
fix a HIP/Frontier issue
86aaf2b 
the amrex::single_task(amrex_check_wavefront_size) check causes runtime
errors
@WeiqunZhang
Merge branch 'development' into fix_hip_issue
e0bbaa6
@WeiqunZhang
comment
8b703ca
@WeiqunZhang WeiqunZhang enabled auto-merge (squash) April 20, 2024 20:01
@WeiqunZhang WeiqunZhang merged commit b752027 into AMReX-Codes:development Apr 20, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @WeiqunZhang