Update for ROCm 6.1.0 #3898
Merged
Update for ROCm 6.1.0 #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A few functions used in Scan have been deprecated in 6.1.0. * Remove -Wno-deprecated-declarations from HIP CIs because we no longer need it. This will help us catch deprecated functions earlier. The flag was added because of atomicNoAdd, which has been handled by `clang diagnostic ignore` in the source code. * No need for -Wno-gnu-zero-variadic-macro-arguments in HIP CIs anymore.
WeiqunZhang
force-pushed
the
hip6.1.0_deprecation
branch
from
294ab2b to
6f39429
Compare
jmsexton03
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few functions used in Scan have been deprecated in 6.1.0.
Remove -Wno-deprecated-declarations from HIP CIs because we no longer need it. This will help us catch deprecated functions earlier. The flag was added because of atomicNoAdd, which has been handled by
clang diagnostic ignorein the source code.No need for -Wno-gnu-zero-variadic-macro-arguments in HIP CIs anymore.