Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FabArray<FAB>::copy Argument Name #3856

Merged
merged 1 commit into from
Mar 28, 2024
Merged

FabArray<FAB>::copy Argument Name #3856

merged 1 commit into from
Mar 28, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 27, 2024

Summary

Rename the argument to src in lieu of Doxygen strings and consistent with other overloads :D

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l ax3l added the cleaning label Mar 27, 2024
@ax3l ax3l requested a review from WeiqunZhang March 27, 2024 22:15
@ax3l
FabArray<FAB>::copy Argument Name
d2100ba 
Rename the argument to `src` in lieu of Doxygen strings :D
@ax3l ax3l force-pushed the topic-fa-copy-src branch from 58c4339 to d2100ba Compare March 28, 2024 00:23
@WeiqunZhang WeiqunZhang enabled auto-merge (squash) March 28, 2024 01:42
@WeiqunZhang WeiqunZhang merged commit dffdeac into AMReX-Codes:development Mar 28, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees

@WeiqunZhang WeiqunZhang

Labels
cleaning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @WeiqunZhang