AMReX_FLATTEN_FOR #3855
Merged
AMReX_FLATTEN_FOR #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new build option to force flattening of ParallelFor and similar functions for host device. The default is yes unless it's a debug build. The CMake option is AMReX_FLATTEN_FOR, whereas for GNU make, it's USE_FLATTEN_FOR.
|
A GCC CI failed with |
asalmgren
pushed a commit
that referenced
this pull request
Mar 29, 2024
Flattening (#3855) makes compilation too slow for some codes. For example, on my desktop, the compilation time for Castro_react.cpp increased from 3 minutes to 49 minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new build option to force flattening of ParallelFor and similar functions for host device. The default is yes unless it's a debug build. The CMake option is AMReX_FLATTEN_FOR, whereas for GNU make, it's USE_FLATTEN_FOR.