GCC: inline limit #3841
Merged
GCC: inline limit #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiqunZhang
force-pushed
the
gcc-inline-limit
branch
from
b6a76b3 to
66edf8e
Compare
WeiqunZhang
force-pushed
the
gcc-inline-limit
branch
2 times, most recently
from
dc9b1d5 to
33701ff
Compare
|
I tested this with Castro and GCC 13.2 and I didn't see any measureable performance difference. |
|
The hotspot functions in Castro are perhaps already inlined. Or they are so expensive that the cost of not inlining does not matter. |
WeiqunZhang
force-pushed
the
gcc-inline-limit
branch
from
33701ff to
0b66da7
Compare
By default, set GCC inline limit to a huge number (43210). GCC's default value is version dependent. It appears to be smaller than 2000 in recent versions. The motivation for setting this to a huge number is that GCC especially the recent versions (e.g., 12) no longer inline big lambda functions passed to ParallelFor, resulting in serious performance issues.
WeiqunZhang
force-pushed
the
gcc-inline-limit
branch
from
0b66da7 to
9ac8752
Compare
jmsexton03
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, set GCC inline limit to a huge number (43210). GCC's default value is version dependent. It appears to be smaller than 2000 in recent versions. The motivation for setting this to a huge number is that GCC especially the recent versions (e.g., 12) no longer inline big lambda functions passed to ParallelFor, resulting in serious performance issues.