Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert range based for-loop with OMP #3839

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Revert range based for-loop with OMP #3839

merged 1 commit into from
Mar 23, 2024

Conversation

roelof-groenewald
Copy link
Contributor

@roelof-groenewald roelof-groenewald commented Mar 22, 2024 •
edited
Loading

Summary

WarpX CI build with OMP < 5 fails due to unsupported range based for-loop. This PR reverts the breaking for-loop to a normal one.

Additional background

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@roelof-groenewald roelof-groenewald marked this pull request as ready for review March 22, 2024 23:47
@WeiqunZhang WeiqunZhang merged commit a863358 into AMReX-Codes:development Mar 23, 2024
69 checks passed
@roelof-groenewald roelof-groenewald deleted the revert_omp_loops branch March 23, 2024 04:15
@ax3l ax3l added the bug label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roelof-groenewald @WeiqunZhang @ax3l