Clang-Tidy 17: cppcoreguidelines-rvalue-reference-param-not-moved #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
approved these changes
Mar 25, 2024
|
I am in the process of updating to clang-tidy 17. A few more PRs are coming.
…On Sun, Mar 24, 2024, 6:25 PM Axel Huebl ***@***.***> wrote:
***@***.**** approved this pull request.
Great pass.
Want to add the option to our clang tidy file in .clang-tidy?
—
Reply to this email directly, view it on GitHub
<#3825 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB37TYLL3D2AA5SJRXBVKHTYZ54HLAVCNFSM6AAAAABE6PKTSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWG4ZDQNZXGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
This particular check is only available in more recent versions of
clang-tidy.
…On Sun, Mar 24, 2024, 6:55 PM Weiqun Zhang ***@***.***> wrote:
I am in the process of updating to clang-tidy 17. A few more PRs are
coming.
On Sun, Mar 24, 2024, 6:25 PM Axel Huebl ***@***.***> wrote:
> ***@***.**** approved this pull request.
>
> Great pass.
>
> Want to add the option to our clang tidy file in .clang-tidy?
>
> —
> Reply to this email directly, view it on GitHub
> <#3825 (review)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB37TYLL3D2AA5SJRXBVKHTYZ54HLAVCNFSM6AAAAABE6PKTSSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNJWG4ZDQNZXGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.