-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tests/OpenMP/atomicAdd #3805
Conversation
Oh, I did it the original way because the code does not work with GPU unless managed memory is used, but it does work even when OMP is off. |
If we let it run for GPU builds, we have to fix the source code. Use RunOn::Device and add a streamSychronize, and possible disable tiling when GPU is on. Also note that when both GPU and OMP are on, atomicAdd and lockAdd will do it on GPU. That effectively disable OMP. |
Oh, ok. I checked the logs and I could not find the test being built in it o.0 |
Oh, I had an extra |
It should read |
Looking through the build logs: should this show up as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I see the Test_OpenMP_atomicAdd_*d
targets being built.
@WeiqunZhang should this test be included in |
Sure |
No description provided.