Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide portable Gpu::Atomic::Multiply and Gpu::Atomic::Divide implemented with CAS. #3724

Merged
merged 7 commits into from
Jan 25, 2024
Merged

Provide portable Gpu::Atomic::Multiply and Gpu::Atomic::Divide implemented with CAS. #3724

merged 7 commits into from
Jan 25, 2024

Conversation

atmyers
Copy link
Member

@atmyers atmyers commented Jan 24, 2024 •
edited
Loading

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@atmyers atmyers requested a review from WeiqunZhang January 24, 2024 20:18
@atmyers atmyers changed the title Provided portable Gpu::Atomic::Multiply and Gpu::Atomic::Divide implemented with CAS. Provide portable Gpu::Atomic::Multiply and Gpu::Atomic::Divide implemented with CAS. Jan 24, 2024
@atmyers @WeiqunZhang
Update Src/Base/AMReX_GpuAtomic.H
58e9394 
Co-authored-by: Weiqun Zhang <WeiqunZhang@lbl.gov>
@atmyers atmyers enabled auto-merge (squash) January 25, 2024 20:00
@atmyers atmyers merged commit 501f92d into AMReX-Codes:development Jan 25, 2024
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang WeiqunZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atmyers @WeiqunZhang