From 47c4f95ffe75e7c8aad6793068abbfebded1c0f2 Mon Sep 17 00:00:00 2001 From: Andrew Myers Date: Tue, 30 Jan 2024 16:42:25 -0800 Subject: [PATCH] Do not use std::forward twice on the same object in AmrParticleLocator (#3734) Bug found by @WeiqunZhang The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate --- Src/Particle/AMReX_ParticleLocator.H | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Src/Particle/AMReX_ParticleLocator.H b/Src/Particle/AMReX_ParticleLocator.H index f4d6301fc80..44bc4904c66 100644 --- a/Src/Particle/AMReX_ParticleLocator.H +++ b/Src/Particle/AMReX_ParticleLocator.H @@ -220,13 +220,13 @@ struct AmrAssignGrid for (int lev = lev_max; lev >= lev_min; --lev) { - int grid = m_funcs[lev](p, 0, std::forward(assignor)); + int grid = m_funcs[lev](p, 0, assignor); if (grid >= 0) { return makeTuple(grid, lev); } } for (int lev = lev_min; lev >= lev_min; --lev) { - int grid = m_funcs[lev](p, nGrow, std::forward(assignor)); + int grid = m_funcs[lev](p, nGrow, assignor); if (grid >= 0) { return makeTuple(grid, lev); } }