Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No flattening of timepoint specific overrides in jax #2641

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

FFroehlich
Copy link
Member

No description provided.

@FFroehlich FFroehlich changed the base branch from master to develop January 31, 2025 12:39
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 95.41284% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.91%. Comparing base (64de63a) to head (e1b5bc4).

Files with missing lines Patch % Lines
python/sdist/amici/jax/model.py 50.00% 4 Missing ⚠️
python/sdist/amici/sbml_import.py 87.50% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (64de63a) and HEAD (e1b5bc4). Click for more details.

HEAD has 20 uploads less than BASE
Flag BASE (64de63a) HEAD (e1b5bc4)
petab 2 0
python 14 4
cpp_python 5 2
cpp 5 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #2641       +/-   ##
============================================
- Coverage    77.06%   36.91%   -40.16%     
============================================
  Files          332      327        -5     
  Lines        23012    22910      -102     
  Branches      1478     1476        -2     
============================================
- Hits         17735     8457     -9278     
- Misses        5266    14436     +9170     
- Partials        11       17        +6     
Flag Coverage Δ
cpp ?
cpp_python 33.38% <20.75%> (-0.04%) ⬇️
petab ?
python 34.43% <95.41%> (-37.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/constants.py 100.00% <100.00%> (ø)
python/sdist/amici/de_model.py 85.15% <100.00%> (-5.01%) ⬇️
python/sdist/amici/de_model_components.py 85.71% <100.00%> (-3.48%) ⬇️
python/sdist/amici/jax/ode_export.py 93.75% <100.00%> (-3.13%) ⬇️
python/sdist/amici/jax/petab.py 86.66% <100.00%> (-10.76%) ⬇️
python/sdist/amici/petab/sbml_import.py 69.65% <100.00%> (-6.37%) ⬇️
python/sdist/amici/sbml_import.py 71.83% <87.50%> (-7.64%) ⬇️
python/sdist/amici/jax/model.py 70.32% <50.00%> (-17.42%) ⬇️

... and 251 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant