Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster parameter mapping #2638

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Faster parameter mapping #2638

merged 1 commit into from
Jan 30, 2025

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Jan 29, 2025

Reduce parameter mapping time for Froehlich_CellSystems2018 by 88% (1774s -> 216s).

@dweindl dweindl added PEtab PEtab-import related performance labels Jan 29, 2025
Reduce parameter mapping time for Froehlich_CellSystems2018 by 88% (1774s -> 216s).
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.02%. Comparing base (57f5ed5) to head (2964828).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2638      +/-   ##
===========================================
- Coverage    77.03%   77.02%   -0.02%     
===========================================
  Files          332      332              
  Lines        22970    22972       +2     
  Branches      1478     1478              
===========================================
- Hits         17695    17694       -1     
- Misses        5264     5267       +3     
  Partials        11       11              
Flag Coverage Δ
cpp 74.13% <0.00%> (-0.02%) ⬇️
cpp_python 33.48% <100.00%> (+<0.01%) ⬆️
petab 38.87% <100.00%> (+0.55%) ⬆️
python 72.10% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/sdist/amici/petab/parameter_mapping.py 82.00% <100.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes

@dweindl dweindl marked this pull request as ready for review January 29, 2025 16:54
@dweindl dweindl requested a review from a team as a code owner January 29, 2025 16:54
@dweindl dweindl merged commit 923b8f4 into AMICI-dev:develop Jan 30, 2025
19 of 20 checks passed
@dweindl dweindl deleted the faster_parmap branch January 30, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance PEtab PEtab-import related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants