Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grainstats entry point #743

Open
Tracked by #517
ns-rse opened this issue Nov 30, 2023 · 0 comments · May be fixed by #1094
Open
Tracked by #517

Grainstats entry point #743

ns-rse opened this issue Nov 30, 2023 · 0 comments · May be fixed by #1094
Labels
ui Issues relating to User Interface v2.4.0

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Nov 30, 2023 •
edited
Loading

Further to #517 add an entry point for topostats grainstats which loads files saved as .topostats (handled by io.LoadScans class) and calculates statistics.

Questions...

  • Should the statistics be saved as part of the HDF5 data? I ask because in batch processing end-to-end the grain statistics are often combined with the tracing statistics so if a user were to load a .topostats file to perform tracing they might expect to have grain statistics combined. Of course if they haven't undertaken grain statistic calculation and jump straight to tracing and tracing statistics this will never be possible.
@ns-rse ns-rse mentioned this issue Nov 30, 2023
Open
14 tasks
@ns-rse ns-rse added the ui Issues relating to User Interface label Nov 30, 2023
@ns-rse ns-rse changed the title Grainstats Grainstats entry point Nov 30, 2023
@ns-rse ns-rse added the v2.4.0 label Jan 15, 2025
ns-rse added a commit that referenced this issue Feb 24, 2025
@ns-rse
feature(grainstats): Adds entry point for grainstats
2a090e0 
Closes #743

Adds an entry point for running GrainStats `process grainstats --help`.

You can test it with...

```
❱ topostats -b tests/resources/test_image -f .topostats grainstats
❱ tree output
[4.0K Feb 24 14:53]  output
├── [2.7K Feb 24 14:53]  output/config.yaml
├── [2.7K Feb 24 14:53]  output/height_profiles.json
├── [1.7K Feb 24 14:53]  output/image_stats.csv
└── [4.0K Feb 24 14:53]  output/processed
    └── [109K Feb 24 14:53]  output/processed/minicircle_small.topostats

2 directories, 4 files
```

Unlike with #1076 only the required directory structure is created.
@ns-rse ns-rse linked a pull request Feb 24, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui Issues relating to User Interface v2.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(grainstats): Adds entry point for grainstats AFM-SPM/TopoStats
1 participant
@ns-rse