Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write trace co-ordinates to file #595

Closed
Tracked by #183
ns-rse opened this issue Jun 1, 2023 · 2 comments
Closed
Tracked by #183

Write trace co-ordinates to file #595

ns-rse opened this issue Jun 1, 2023 · 2 comments
Assignees
Labels
DNATracing Issues pertaining to the DNATracing class duplicate This issue or pull request already exists IO Input and Output

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented Jun 1, 2023

As part of the in-progress DNA Tracing refactoring (#183) the writeCoordinates() method of dnaTrace class has been removed as it was not used anywhere.

@Jean-Du has indicated it is a desirable feature to retain though.

As this is an I/O (Input/Output) operation a new function should be written when refactoring dnaTrace that can be used to write these to file.

Currently multiple np.ndarray are appended so that all grains co-ordinates are written to a single file. With the intended restructuring such that traceDNA class processes individual grains and the looping over multiple grains is handled by topostats.processing.process_scan() then it will have to return the co-ordinates (ideally as a pd.DataFrame) so that they can be concatenated and written to CSV.

@ns-rse ns-rse added DNATracing Issues pertaining to the DNATracing class IO Input and Output labels Jun 1, 2023
@ns-rse ns-rse self-assigned this Jun 1, 2023
@ns-rse
Copy link
Collaborator Author

ns-rse commented Jun 26, 2023

#609 has left a place holder for returning a dictionary or trace co-ordinates as and the structure proposed in #605 will write these dictionaries to disk. Currently this is as a Python pickle but there may be merit/utility in writing to JSON.

This is separate to the work in progress on #601 which is looking great and breaks up the behemoth that process_scan() has become into individual functions that will make extend #517/#540.

@ns-rse
Copy link
Collaborator Author

ns-rse commented Nov 10, 2023

Duplicate of #488

@ns-rse ns-rse marked this as a duplicate of #488 Nov 10, 2023
@ns-rse ns-rse closed this as completed Nov 10, 2023
@ns-rse ns-rse added the duplicate This issue or pull request already exists label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNATracing Issues pertaining to the DNATracing class duplicate This issue or pull request already exists IO Input and Output
Projects
None yet
Development

No branches or pull requests

1 participant