Revise "with when" ranges in MOM5 Spack package

[penguian]

At https://github.com/ACCESS-NRI/spack-packages/blob/main/packages/mom5/package.py there is an "access-esm1.6" version that uses the "master" branch. The second with when uses the inclusive range "@access-esm1.5:access-esm1.6" so version @access-esm1.6 would match the second with when. The first with when uses the range "@:access-esm0,access-esm2:" which matches the preferred @master version. So building mom5@master builds from the same mom5 branch as building mom5@access-esm1.6 but uses a different set of dependencies.

This is wrong. Either we should change the ranges to "@access-esm1.5" and "@:access-esm0,access-esm1.6:" or we should remove the "access-esm1.6" version, or both.

[harshula]

Hi @penguian , IIRC, a MOM5 build for ESM 1.6 does not depend on libaccessom2, so the behaviour you described may be intentional.

The type variant definition should be double checked. Should we have?:

conditional("ACCESS-OM", "ACCESS-OM-BGC", "MOM_solo", when="@:access-esm0,access-esm2:")

[dougiesquire]

Yup, the current behaviour is intentional - see ACCESS-NRI/MOM5#25

[penguian]

Closing due to previous comment.