Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete variables set but not used #9

Open
atteggiani opened this issue Jul 26, 2024 · 0 comments · May be fixed by #55
Open

Delete variables set but not used #9

atteggiani opened this issue Jul 26, 2024 · 0 comments · May be fixed by #55
Assignees
@atteggiani

Comments

@atteggiani
Copy link
Collaborator

atteggiani commented Jul 26, 2024 •
edited
Loading

Some variables are set but never used.
E.g. ec_cb_file:

replace_landsurface/src/replace_landsurface_with_BARRA2R_IC.py

Line 172 in cdb8734

ec_cb_file = ec_cb_file_fullpath.parts[-1].replace('.tmp', '')

Check if the unused variables are effectively not needed and, in case, delete them.
@atteggiani atteggiani mentioned this issue Jul 26, 2024
Open
12 tasks
@atteggiani atteggiani moved this to Parked 🅿️ in ACCESS-RAM3 Jul 26, 2024
@atteggiani atteggiani moved this from Parked 🅿️ to New Issues in ACCESS-RAM3 Jul 26, 2024
@atteggiani atteggiani moved this from New Issues to Todo ⏳ in ACCESS-RAM3 Jul 28, 2024
@atteggiani atteggiani moved this from Todo ⏳ to Review 👏 in ACCESS-RAM3 Jul 31, 2024
@atteggiani atteggiani mentioned this issue Jul 31, 2024
Closed
@atteggiani atteggiani self-assigned this Aug 2, 2024
@atteggiani atteggiani linked a pull request Feb 24, 2025 that will close this issue
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atteggiani atteggiani

Labels
None yet
Projects
ACCESS-RAM3
Status: Todo ⏳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove --mask argument + restructure ACCESS-NRI/replace_landsurface
1 participant
@atteggiani