Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing CI #14

Open
atteggiani opened this issue Jul 26, 2024 · 0 comments · May be fixed by #38
Open

Testing CI #14

atteggiani opened this issue Jul 26, 2024 · 0 comments · May be fixed by #38
Assignees

Comments

@atteggiani
Copy link
Collaborator

It would be great to have some unit tests that could be run as part of CI.

We could implement unit-testing for the helper functions, and a more general test to check that different input files (different location, different size, anything else that might change in the input file) matches the expected output files.

Running any test code on GitHub will require creating a test (conda) environment, which requires a list of dependencies and versions. An issue with this might arise due to possible mismatch between this test environment and the one used when running the model on NCI (e.g. hh5's conda environment).
There could be solutions to this but they need to be discussed.

An alternative solution could be running tests remotely on NCI.
This would solve any potential environment mismatch problem and may be required anyway (depending on the minimum size of testing file we can achieve).
Could we run CI on GitHub that executes tests remotely on NCI? Could this be a feasible solution?

This issue will likely be split in multiple separate issues.

@atteggiani atteggiani moved this to Parked 🅿️ in ACCESS-RAM3 Jul 26, 2024
@atteggiani atteggiani moved this from Parked 🅿️ to New Issues in ACCESS-RAM3 Jul 26, 2024
@atteggiani atteggiani moved this from New Issues to Todo ⏳ in ACCESS-RAM3 Jul 28, 2024
@atteggiani atteggiani self-assigned this Aug 2, 2024
@atteggiani atteggiani moved this from Todo ⏳ to In Progress 🏗️ in ACCESS-RAM3 Aug 12, 2024
@atteggiani atteggiani linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress 🏗️
Development

Successfully merging a pull request may close this issue.

1 participant