From e6a490df2417737158c769eca19159b3f7e57258 Mon Sep 17 00:00:00 2001
From: hyeneung <imasaru22@gmail.com>
Date: Sat, 30 Nov 2024 20:05:18 +0900
Subject: [PATCH] fix: Change usableDonation to usedDonation in response DTO

---
 .../statistics/controller/StatisticsController.java |  6 +++---
 .../dto/response/UtilizationStatisticsElement.java  | 13 ++++++-------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/src/main/java/com/example/mymoo/domain/statistics/controller/StatisticsController.java b/src/main/java/com/example/mymoo/domain/statistics/controller/StatisticsController.java
index 7c359dc..ce5e433 100644
--- a/src/main/java/com/example/mymoo/domain/statistics/controller/StatisticsController.java
+++ b/src/main/java/com/example/mymoo/domain/statistics/controller/StatisticsController.java
@@ -30,7 +30,7 @@ public class StatisticsController {
     @GetMapping("children")
     public ResponseEntity<ChildStatisticsDTO> getChildStatistics(
     ){
-        return ResponseEntity.status(HttpStatus.ACCEPTED).body(
+        return ResponseEntity.status(HttpStatus.OK).body(
                 statisticsService.getChildStatistics()
         );
     }
@@ -45,7 +45,7 @@ public ResponseEntity<ChildStatisticsDTO> getChildStatistics(
     @GetMapping("utilizations")
     public ResponseEntity<UtilizationStatisticsDTO> getUtilizationStatistics(
     ){
-        return ResponseEntity.status(HttpStatus.ACCEPTED).body(
+        return ResponseEntity.status(HttpStatus.OK).body(
                 statisticsService.getUtilizationStatistics()
         );
     }
@@ -60,7 +60,7 @@ public ResponseEntity<UtilizationStatisticsDTO> getUtilizationStatistics(
     @GetMapping("stores")
     public ResponseEntity<StoreStatisticsDTO> getStoreStatistics(
     ){
-        return ResponseEntity.status(HttpStatus.ACCEPTED).body(
+        return ResponseEntity.status(HttpStatus.OK).body(
                 statisticsService.getStoreStatistics()
         );
     }
diff --git a/src/main/java/com/example/mymoo/domain/statistics/dto/response/UtilizationStatisticsElement.java b/src/main/java/com/example/mymoo/domain/statistics/dto/response/UtilizationStatisticsElement.java
index 46de1a5..f84c094 100644
--- a/src/main/java/com/example/mymoo/domain/statistics/dto/response/UtilizationStatisticsElement.java
+++ b/src/main/java/com/example/mymoo/domain/statistics/dto/response/UtilizationStatisticsElement.java
@@ -9,7 +9,7 @@
 public class UtilizationStatisticsElement {
     private String address;
     private Long allDonation;
-    private Long usableDonation;
+    private Long usedDonation;
     private Double utilization;
 
     public UtilizationStatisticsElement(
@@ -23,13 +23,12 @@ public UtilizationStatisticsElement(
         if (guName != null){
             this.address += " "+guName;
         }
-        this.allDonation = allDonation;
-        this.usableDonation = usableDonation;
-        if (allDonation != null && allDonation > 0) {
+        this.allDonation = allDonation != null ? allDonation : 0L;
+        this.usedDonation = this.allDonation - (usableDonation != null ? usableDonation : 0L);
+        if (this.allDonation > 0) {
             this.utilization = BigDecimal.valueOf(
-                    usableDonation != null ?
-                            (allDonation.doubleValue()-usableDonation.doubleValue())*100 / allDonation.doubleValue() : 0.0)
-                    .setScale(2, RoundingMode.HALF_UP).doubleValue();
+                this.usedDonation*100 / this.allDonation
+            ).setScale(2, RoundingMode.HALF_UP).doubleValue();
         } else {
             this.utilization = 0.0;
         }