refactor: remove unnecessary else clause and discard stale data

6lr61 · Sep 12, 2024 · 49b7019 · 49b7019
1 parent 2f5fdbe
commit 49b7019
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/contexts/UserProfileProvider.tsx b/src/contexts/UserProfileProvider.tsx
@@ -16,23 +16,28 @@ export default function UserProfileProvider({
   const authState = authStateContext?.authState;
   const [userData, setUserData] = useState<UserData | null>(null);
 
-  // TODO: Add a clean-up function!
   useEffect(() => {
+    let keep = true;
+
     if (authState) {
       getUser(
         authState.token.value,
         authState.client.id,
         login ?? authState.user.login
       )
         .then((data) => {
-          setUserData(data);
+          if (keep) {
+            setUserData(data);
+          }
         })
         .catch((error: unknown) => {
           console.error("UserProfile:", error);
         });
-    } else {
-      setUserData(null);
     }
+
+    return () => {
+      keep = false;
+    };
   }, [authState, login]);
 
   return (