Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for testing against Trilinos develop #295

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ppraegla
Copy link
Member

@ppraegla ppraegla commented Jan 28, 2025

Description and Context

Adds a workflow that builds the Docker image with the Trilinos develop version, builds 4C, and runs the tests.
This is a draft for now because

  1. the build fails (something with arborX) and
  2. the workflow schedule is not finalized yet. Ideally, I would like to run this workflow weekly and allow the option to run the workflow manually for specific commit SHAs. However, I have not yet found a nice way to add the manual trigger without duplicating the jobs.

@maxfirmbach , @eulovi (I added you to my fork. So you can directly push to my branch. Hopefully, this works)

Related Issues and Merge Requests

#288, #291, #290

@maxfirmbach
Copy link
Contributor

Yeah ArborX throws warnings most likely, due to it being a quite old version compared to Kokkos ... I currently don't have the time to look into this in detail though ...

@ppraegla
Copy link
Member Author

@maxfirmbach Should we wait with this PR until we update ArborX? In #290, you said you want to wait until the next official ArborX release. I'm hesitant to add a workflow now that will immediately fail.

@maxfirmbach
Copy link
Contributor

@maxfirmbach Should we wait with this PR until we update ArborX? In #290, you said you want to wait until the next official ArborX release. I'm hesitant to add a workflow now that will immediately fail.

@ppraegla That's fine for me 👍.

@aprokop
Copy link

aprokop commented Jan 28, 2025

Yeah ArborX throws warnings most likely, due to it being a quite old version compared to Kokkos ... I currently don't have the time to look into this in detail though ...

Hi, ArborX developer here. This has been fixed fixed upstream in arborx/ArborX#1183.

Next ArborX release should happen within a month. Functionally, it's all there, but currently going through some performance regression testing and minor API tweaking.

@maxfirmbach
Copy link
Contributor

Yeah ArborX throws warnings most likely, due to it being a quite old version compared to Kokkos ... I currently don't have the time to look into this in detail though ...

Hi, ArborX developer here. This has been fixed fixed upstream in arborx/ArborX#1183.

Next ArborX release should happen within a month. Functionally, it's all there, but currently going through some performance regression testing and minor API tweaking.

Great 👍 Maybe @isteinbrecher and me have a look at the changes made to ArborX soonish.

@isteinbrecher
Copy link
Contributor

Thanks @aprokop for letting us know! Yes, @maxfirmbach lets have a look at the changes in the next weeks.

@mayrmt
Copy link
Member

mayrmt commented Feb 20, 2025

@maxfirmbach @isteinbrecher what's the status here?

@maxfirmbach
Copy link
Contributor

@maxfirmbach @isteinbrecher what's the status here?

No update yet, need to fix the ArborX related problems first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants