Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance workflows #6585

Closed
wants to merge 4 commits into from
Closed

Enhance workflows #6585

wants to merge 4 commits into from

Conversation

UltraFeed
Copy link
Contributor

@UltraFeed UltraFeed commented Jan 24, 2025

  1. Addressed an issue where opening any build-{architecture}.yml file in Visual Studio could trigger the error Missing property 'description'.

  2. Fixed indentation in the feature_request YAML file.

  3. Removed branch restrictions from on: push, allowing workflows to run on branches with any name.

  4. Added on: pull_request Event Trigger to prevent merging broken code.

@UltraFeed UltraFeed changed the title Fix yaml files Enhance workflows Jan 24, 2025
@2dust
Copy link
Owner

2dust commented Jan 25, 2025

Thanks for the PR.
These are not important and will not be processed for now.

@2dust 2dust closed this Jan 25, 2025
@UltraFeed
Copy link
Contributor Author

UltraFeed commented Jan 25, 2025

I’m a bit unclear about the reason for the rejection. Could you please clarify which aspects of the proposed changes are not considered important at this time? I believe running workflows on PRs is a valuable feature.

@2dust
Copy link
Owner

2dust commented Jan 28, 2025

It means you submitted some optional code.
For example: description: "Tag for the release (optional)"

For example:

 push:
branches:
- '*'
pull_request:
branches:
- '*'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants