Bugfix/47995 incorrect precision #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bogdan202
commented
Sep 18, 2024
bogdan202
commented
| Questions | Answers |
|---|---|
| Description? | The module tries to refund an incorrect amount |
| Type? | bug fix / improvement / new feature / refacto / critical |
| BC breaks? | yes / no |
| Deprecations? | yes / no |
| Fixed ticket? | Fixes #{issue number here}. |
| How to test? | PrestaShop 1.7.7 or higher. Default currency is JPY. Create an order and pay it with EUR. Update order status to 'Refund' |
kgleizes
reviewed
Sep 18, 2024
| @@ -50,7 +49,7 @@ public function calculate($params) | |||
| } | |||
|
|
|||
| foreach ($params['productList'] as $product) { | |||
| $amount += \Tools::ps_round($product['amount'], PayPal::getPrecision()); | |||
| $amount += (float) $product['amount']; | |||
There was a problem hiding this comment.
Hello Bogdan, i don't really understand why we remove the round with precision after changing it on paypal.php main class.
Why we don't use it once corrected with correct currency ?
Rounding is almost done after adding every product to the count (in another function) ?
There was a problem hiding this comment.
Redundant action. In fact, rounding is done here:
https://github.com/202ecommerce/paypal/blob/6.4.2/classes/API/Request/PaypalOrderPartialRefundRequest.php#L44
kgleizes
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.