Add simple time slider to map view

[DavidMStraub]

Hi @1ec5, I added a simple time range slider to the map - it doesn't yet do anything, except setting properties on the map view. I can add filtering on the map pins later. How would we now filter the OHM layer?

[1ec5]

Thanks so much for putting this together – range sliders are very cool and we need to use them more in OHM too. I do wonder if a single-knob slider would be more logical in some of the map views, where we don’t overlay a bunch of pins that you might want to filter. But we can figure that out separately.

[DavidMStraub]

I do wonder if a single-knob slider would be more logical in some of the map views, where we don’t overlay a bunch of pins that you might want to filter.

Yes indeed. Perhaps a single-knob slider and a button/dropdown to select a range of ±5, ±10, ±50, ±100 years around the selected date to filter the pins?

[DavidMStraub]

I changed it to a normal slider now and added the filter methods; however it doesn't seem to work yet; or it works only once, to be precise. Not sure what I'm doing wrong.

[1ec5]

Thanks so much for figuring out a nice-looking UI for this. From what I can tell, the main things to sort out are:

• Show and hide the time slider based on the active layer
• How should the time slider filter pins? Would we show all the events up to the selected date? Or should time-based pin filtering be a separate control in the dialog box accessible from the funnel button in the search bar?

Do you want to keep working on this branch or merge into gramps-project#454 and work on it there? (I enabled edits by maintainers so you can push commits directly to that branch.)

[DavidMStraub]

Agreed!

Show and hide the time slider based on the active layer

I was thinking we could leave it present all the time if it's also used to filter pins. In the OSM case it would affect only pins, in the OHM case map & pins.

How should the time slider filter pins? Would we show all the events up to the selected date? Or should time-based pin filtering be a separate control in the dialog box accessible from the funnel button in the search bar?

I added the 1924 ± 10 without function but I was thinking the ± x could be clickable to select a wider range. We could then show all the pins in that time period (e.g. in which places did my ancestors have events at in the 18th century).

Do you want to keep working on this branch or merge into gramps-project#454 and work on it there? (I enabled edits by maintainers so you can push commits directly to that branch.)

Yes, let's do it like that, as soon as the pin filtering is implemented we can then merge the main PR.

Edit: I meant yes, let's merge this into your openhistoricalmap-437 feature branch.

[1ec5]

Sounds good to me!