Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize current reporting period and reverse order #1806

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

peterrowland
Copy link
Contributor

Description

Reverses the order of uncompleted reporting periods and bolds the current week.

Additional information

This is a solution to #1770, but not the one that was suggested and mocked up for reasons described here.

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (9b80c41) to head (85d2251).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1806   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files          66       66           
  Lines        4177     4177           
=======================================
  Hits         3934     3934           
  Misses        243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cantsin cantsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change is reasonable to me. LGTM

@cantsin cantsin merged commit 6f1d685 into main Oct 4, 2024
2 checks passed
@cantsin cantsin deleted the highlight_currentWeek branch October 4, 2024 18:19
@peterrowland peterrowland requested review from cantsin and removed request for cantsin October 4, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants