Allow zero for project allocation on hourly projects #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cantsin
approved these changes
Mar 13, 2024
| self.cleaned_data['project_allocation'] != ''): | ||
| if ( | ||
| "project_allocation" in self.cleaned_data | ||
| and not self._is_empty_or_zero( |
There was a problem hiding this comment.
do we need the staticmethod decorator here? Shouldn't we call it as TimecardObjectForm._is_empty_or_zero to be clearer?
There was a problem hiding this comment.
We don't strictly need to use @staticmethod, but I think it's good practice when we don't need to use any properties of the instance or the class. As far as calling the method, self works and is much less verbose than having to repeat the class name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1728 was tracked down to a situation where the timecard form might submit "0" for project allocation even for hourly billing projects. This changes the form cleaning code to allow that possibility without raising the error message from the bug.
We add a test for the situation that fails in our current code and passes with the fix.
Additional information
There are a couple unrelated changes where
or Nonewas removed where it wasn't doing anything.Fixes #1728