Skip to content
This repository has been archived by the owner on Nov 14, 2019. It is now read-only.

Switch to eslint #148

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Switch to eslint #148

wants to merge 9 commits into from

Conversation

mgwalker
Copy link
Member

This PR switches to eslint from jshint, adopts (most of) the 18F standard (eslint-config-airbnb, and fixes all the linter errors.

It's... big.

@codecov-io
Copy link

codecov-io commented Sep 30, 2017

Codecov Report

Merging #148 into develop will increase coverage by 1.28%.
The diff coverage is 89.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
+ Coverage    85.13%   86.41%   +1.28%     
===========================================
  Files           58       58              
  Lines         1372     1318      -54     
  Branches       181      182       +1     
===========================================
- Hits          1168     1139      -29     
+ Misses         204      179      -25
Impacted Files Coverage Δ
lib/helpers/reports/transformers/index.js 92.85% <ø> (ø) ⬆️
lib/bot/setOutOfOffice.js 19.51% <0%> (-1.01%) ⬇️
lib/bot/respondToUnhandledDM.js 50% <0%> (ø) ⬆️
lib/bot/joinChannel.js 100% <100%> (ø) ⬆️
lib/helpers/reports/convertStandups.js 100% <100%> (ø) ⬆️
features/support/setup.js 100% <100%> (ø) ⬆️
lib/bot/removeStandup.js 100% <100%> (ø) ⬆️
features/steps/set-reminder.js 100% <100%> (ø) ⬆️
lib/bot/startInterview.js 100% <100%> (ø) ⬆️
lib/bot/replyToBadStandup.js 100% <100%> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51556d2...d1ef21d. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants