Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign script output name in ESBuild command #440

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Apr 26, 2024

🛠 Summary of changes

Updates JavaScript build script to perform the rename of auto.js source script to main.js dist script as part of the ESBuild command itself, using custom output path support.

This is both simpler, and will hopefully address some inconsistent issues where the post-build script isn't always run as expected, resulting in a scenario where main.js 404s.

📜 Testing Plan

  1. npm start
  2. Visit http://localhost:4000
  3. Observe no errors in the developer tools console, and script loading works as expected (e.g. banner is not expanded by default)

@aduth aduth merged commit fdabcea into main Apr 26, 2024
4 checks passed
@aduth aduth deleted the aduth-esbuild-output-name branch April 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants