Fix broken links in the guides #763
Merged
+10
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelle-rago
requested review from
quarterback,
a team and
jasnakai
as code owners
quarterback
previously approved these changes
Dec 4, 2024
mgwalker
previously approved these changes
Dec 4, 2024
mgwalker
reviewed
Dec 4, 2024
mgwalker
previously approved these changes
Dec 4, 2024
|
Thank you, @mgwalker! |
durland18F
approved these changes
Dec 11, 2024
|
How many approvals do I need??? |
So, either someone on the @18F/18f-engineering-leadership group or @quarterback have to approve the latest set of changes. |
|
Bah! I had previously approved them, but I guess it revokes approvals when there are changes now. Approval incoming! |
|
This flow is like if Concur built approval. Just keep approving! Eventually it'll go! |
cantsin
approved these changes
Dec 11, 2024
|
Guess we still need the quarterback...this is fun! Next time I won't mash up changes from different guides into one PR (I guess that's better?) |
quarterback
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: