-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added release checklist page #741
Conversation
@alexbielen @hbillings Ready for your review :) |
overall looks strong @kewlguy781 -- thank you for your work on this and for editing through multiple drafts! I see one area where it looks like some suggested edits from the Google Doc didn't fully come across right, will make a suggestion there. otherwise I think this is on the right track, thanks again |
minor edit as per review Co-authored-by: Alex Soble <96746002+alexsobledotgov@users.noreply.github.com>
@alexbielen -- you're not needed here as a reviewer, correct? if so feel free to unassign yourself |
@hbillings this is ready for your review as Director! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a good revision! I left a few minor comments, and have one larger question to consider:
What do we mean when we say release
? Some of these items are applicable for major releases, like site launches or big new feature introduction, while others could also be applicable for smaller releases. But if we're saying these should be applied to smaller releases also, it seems like we're endorsing a release management model over a continuous deployment model. (That feels like a philosophical debate we don't necessarily need to wade into here!) Curious what your initial intent was, Jon!
Applying some suggestions from peer, Thanks! Co-authored-by: Heather Billings <heather.battaglia@gsa.gov> Co-authored-by: Greg Walker <mgwalker@users.noreply.github.com>
Co-authored-by: Alex Soble <96746002+alexsobledotgov@users.noreply.github.com>
Co-authored-by: Alex Soble <96746002+alexsobledotgov@users.noreply.github.com>
@kewlguy781 -- Heather likely won't be able to review this week because of performance review season. So I added a few suggested edits related to the title for your consideration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me pending others' agreement!
Co-authored-by: Alex Soble <96746002+alexsobledotgov@users.noreply.github.com>
made some minor changes to reflect it as software launch checklist instead of release checklist
Changes proposed in this pull request:
Added a better release checklist based on feedback.
security considerations
There are links to the google drive, but requires GSA account (Launch Prep and example of other project checklists)