Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qasp.md #518

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Update qasp.md #518

merged 2 commits into from
Apr 1, 2024

Conversation

amandarkennedy
Copy link
Contributor

@amandarkennedy amandarkennedy commented Mar 29, 2024

Take two! Re-doing the changes attempted in #466.

Changes proposed in this pull request:

  • Added line break between "code base" and "Version controlled".
  • Added a period at the end of "A system diagram is provided."

security considerations

none

Take two! Re-doing the changes attempted in #466. 

Added line break between "code base" and "Version controlled". Added a period at the end of "A system diagram is provided."
@amandarkennedy amandarkennedy requested a review from a team March 29, 2024 19:39
@juliaklindpaintner
Copy link
Contributor

juliaklindpaintner commented Mar 29, 2024

@amandarkennedy Thanks for redoing this! Looking at the preview, the period was added, but the line break didn't come through. I think you need to add <br> rather than just a return for it to register.

@amandarkennedy
Copy link
Contributor Author

oh that's right. let me fix. thanks @juliaklindpaintner !

@amandarkennedy
Copy link
Contributor Author

I think it is updated now @juliaklindpaintner ?

Copy link
Contributor

@juliaklindpaintner juliaklindpaintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amandarkennedy amandarkennedy merged commit f13fd00 into main Apr 1, 2024
6 checks passed
@amandarkennedy amandarkennedy deleted the amandarkennedy-patch-1 branch April 1, 2024 10:50
@amandarkennedy
Copy link
Contributor Author

@juliaklindpaintner thank you! just merged the PR. can you please remind me if there is anything else I need to do so the update shows up on the live version? https://guides.18f.gov/derisking/qasp/

@juliaklindpaintner
Copy link
Contributor

juliaklindpaintner commented Apr 1, 2024 via email

@amandarkennedy
Copy link
Contributor Author

amandarkennedy commented Apr 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants