-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update qasp.md #518
Update qasp.md #518
Conversation
Take two! Re-doing the changes attempted in #466. Added line break between "code base" and "Version controlled". Added a period at the end of "A system diagram is provided."
@amandarkennedy Thanks for redoing this! Looking at the preview, the period was added, but the line break didn't come through. I think you need to add |
oh that's right. let me fix. thanks @juliaklindpaintner ! |
I think it is updated now @juliaklindpaintner ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@juliaklindpaintner thank you! just merged the PR. can you please remind me if there is anything else I need to do so the update shows up on the live version? https://guides.18f.gov/derisking/qasp/ |
Looks like it's showing up now!
…On Mon, Apr 1, 2024, 6:52 AM amandarkennedy ***@***.***> wrote:
@juliaklindpaintner <https://github.com/juliaklindpaintner> thank you!
just merged the PR. can you please remind me if there is anything else I
need to do so the update shows up on the live version?
https://guides.18f.gov/derisking/qasp/
—
Reply to this email directly, view it on GitHub
<#518 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKH5WKCDFQALUYRT3BX262DY3E37FAVCNFSM6AAAAABFO23ZEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGU3TKMRRGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
YAY ok thanks :)
On Mon, Apr 1, 2024 at 10:33 AM Julia Lindpaintner ***@***.***>
wrote:
… Looks like it's showing up now!
On Mon, Apr 1, 2024, 6:52 AM amandarkennedy ***@***.***>
wrote:
> @juliaklindpaintner <https://github.com/juliaklindpaintner> thank you!
> just merged the PR. can you please remind me if there is anything else I
> need to do so the update shows up on the live version?
> https://guides.18f.gov/derisking/qasp/
>
> —
> Reply to this email directly, view it on GitHub
> <#518 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AKH5WKCDFQALUYRT3BX262DY3E37FAVCNFSM6AAAAABFO23ZEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGU3TKMRRGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#518 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5CT6AS5H4LK7FHETJEXHDDY3FV25AVCNFSM6AAAAABFO23ZEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZHA2TCOBXGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Amanda Kennedy (she/her)
18F <https://18f.gsa.gov/> | Technology Transformation Service
<http://www.gsa.gov/portal/category/25729> | GSA
<http://www.gsa.gov/portal/category/100000>
***@***.***
|
Take two! Re-doing the changes attempted in #466.
Changes proposed in this pull request:
security considerations
none