Port page descriptions from old site #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use in meta tags Relates to #352
jduss4
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Functionally, I think this will work fine. Practically, I'm wondering if, since description appears to be identical to method.what, if there is a way to only use one of them. Maybe method whats pull from description instead, or the meta tag looks for description and then method.what? It feels very duplicative to have both in these templates.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Since page descriptions are used in meta tags, we should port over the descriptions from the old site.
Relates to #352
security considerations
None / content change only