Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods design review quick fixes #423

Merged
merged 8 commits into from
Dec 28, 2023
Merged

Methods design review quick fixes #423

merged 8 commits into from
Dec 28, 2023

Conversation

echappen
Copy link
Contributor

@echappen echappen commented Dec 27, 2023 •
edited
Loading

@echappen echappen requested a review from a team as a code owner December 27, 2023 16:42
@echappen echappen requested review from janelx and removed request for a team December 27, 2023 16:43
@echappen
Fixes #374
362f89c 
Change how method markdown content is rendered

This allows us to remove the extra markdown files and keep the method markdown in the same file as the frontmatter
This was referenced Dec 27, 2023
Merged
Merged
janelx
janelx reviewed Dec 28, 2023
View reviewed changes
Copy link

@janelx janelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the UX Guide, if this is the correct QA build it is missing the highlighted text for #419. All other bugs have been have been fixed and look good.

@echappen
Copy link
Contributor Author

@janelx Here's the build page for methods usability test script. I'll make a separate issue for the ux guide.

@echappen echappen requested a review from janelx December 28, 2023 18:48
@echappen echappen merged commit 3108049 into main Dec 28, 2023
6 checks passed
@echappen echappen deleted the eoc/methods-design-review-1 branch December 28, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janelx janelx janelx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@echappen @janelx