Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging further #781

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Improve logging further #781

merged 2 commits into from
Feb 5, 2024

Conversation

levinmr
Copy link
Contributor

@levinmr levinmr commented Feb 5, 2024

  • Catch execution errors in index.js and log them appropriately.
  • Remove duplicate log level tags from being output in cron.js
  • Replace missed logger in ua/index.js
  • Add logging to JSON formatter to catch circular JSON bug

Catch execution errors in index.js and log them appropriately.
Remove duplicate log level tags from being output in cron.js
Replace missed logger in ua/index.js
@levinmr levinmr force-pushed the improve_logging_part_2 branch from 8319cfa to 0416d98 Compare February 5, 2024 15:31
Copy link
Contributor

@XavierMetichecchia XavierMetichecchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@levinmr levinmr merged commit ba1eeb2 into develop Feb 5, 2024
4 checks passed
@levinmr levinmr deleted the improve_logging_part_2 branch February 5, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants